Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IEN-937 | Add restriction to BCCNM spreadsheet file upload #666

Merged
merged 3 commits into from
Oct 17, 2024
Merged

IEN-937 | Add restriction to BCCNM spreadsheet file upload #666

merged 3 commits into from
Oct 17, 2024

Conversation

jerry-ey
Copy link
Collaborator

@jerry-ey jerry-ey commented Oct 17, 2024 •
edited
Loading

Changes

  • Add file size 6MB restriction
  • Refactor the existing code: Don't need to check extension as react-dropzone returns empty file if the ext is not correct.

Screenshots

Deployed to TEST and verified.

  • When the ext is not correct
    CleanShot 2024-10-17 at 11 03 21

  • When file size > 6MB
    CleanShot 2024-10-17 at 11 04 49

dbayly-freshworks
dbayly-freshworks approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@dbayly-freshworks dbayly-freshworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all looks good. One small comment

apps/web/src/components/FileUploader.tsx Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jerry-ey jerry-ey merged commit 05bbbc2 into main Oct 17, 2024
6 checks passed
@jerry-ey jerry-ey deleted the IEN-937 branch October 17, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbayly-freshworks dbayly-freshworks dbayly-freshworks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerry-ey @dbayly-freshworks @c1495616js