fix: increase whitespace between mean and median charts #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent on style definitions in the surrounding page
…ow 'prefer not to say /' to be included all on one line.
…ow 'prefer not to say /' to be included all on one line.
sukanya-rath
approved these changes
May 16, 2024
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two CSS style classes used in the HTML report (ps-2 and pe-2) weren't defined as embedded styles within the report, so the report depended on finding definitions for these styles in the surrounding page (into which the HTML report gets injected). This worked for the HTML version of the report when viewed through the PT application, but the styles remain undefined for the PDF report. I addressed this by embedding definitions for both styles into the report.
This fixes a whitespace issue between the side-by-side "mean" and "median" charts in the application (i.e. there's now sufficient horizontal whitespace between the charts).
Also slightly widened the right margin beside the "mean" and "median" charts so that the line break within "Prefer not to say / Unknown" occurs after the slash.
Fixes # GEO-616
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Visual inspection of the HTML and PDF reports.
Checklist
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: