Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Delete reports #460

Merged
merged 17 commits into from
May 27, 2024
Merged

feat: Delete reports #460

merged 17 commits into from
May 27, 2024

Conversation

goemen
Copy link
Contributor

@goemen goemen commented May 6, 2024 •
edited by github-actions bot
Loading

Description

Add endpoint to delete reports using company Id

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@goemen goemen requested a review from sukanya-rath as a code owner May 6, 2024 16:09
@goemen goemen changed the title Feat: Delete reports feat: Delete reports May 6, 2024
sukanya-rath
sukanya-rath requested changes May 7, 2024
View reviewed changes
backend-external/src/config/index.ts Outdated Show resolved Hide resolved
backend-external/src/v1/routes/pay-transparency-routes.ts Outdated Show resolved Hide resolved
backend-external/src/v1/routes/pay-transparency-routes.ts Outdated Show resolved Hide resolved
backend/src/config/index.ts Outdated Show resolved Hide resolved
backend/src/external-consumer-app.ts Show resolved Hide resolved
backend/src/v1/routes/external-consumer-routes.ts Outdated Show resolved Hide resolved
backend/src/v1/services/external-consumer-service.ts Outdated Show resolved Hide resolved
charts/fin-pay-transparency/charts/backend-external/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/fin-pay-transparency/templates/secret.yaml Outdated Show resolved Hide resolved
charts/fin-pay-transparency/templates/secret.yaml Outdated Show resolved Hide resolved
@goemen goemen force-pushed the delete-reports branch from 6afa15c to a1e5513 Compare May 8, 2024 18:47
@goemen goemen requested a review from sukanya-rath May 27, 2024 17:45
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Pay Transparency backend-external'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Pay Transparency Frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Pay Transparency Backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Pay Transparency doc-gen-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sukanya-rath sukanya-rath merged commit 9bde67a into main May 27, 2024
29 checks passed
@sukanya-rath sukanya-rath deleted the delete-reports branch May 27, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukanya-rath sukanya-rath sukanya-rath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goemen @sukanya-rath