Bug/chart summary text rounding (#174)

Co-authored-by: Sukanya Rath <[email protected]>
bcgov · Jan 23, 2024 · 5609e35 · 5609e35
1 parent fde305a
commit 5609e35
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/backend/src/v1/services/report-service.spec.ts b/backend/src/v1/services/report-service.spec.ts
@@ -253,7 +253,7 @@ describe('getWageGapTextSummary', () => {
         isSuppressed: false,
       };
       mockCalcs[CALCULATION_CODES.MEDIAN_BONUS_PAY_DIFF_W] = {
-        value: 10,
+        value: 10.2,
         isSuppressed: false,
       };
       mockCalcs[CALCULATION_CODES.MEDIAN_BONUS_PAY_DIFF_X] = {
@@ -304,7 +304,7 @@ describe('getWageGapTextSummary', () => {
       expect(text).toContain('median');
       expect(text).toContain('bonus pay');
       expect(text).toContain(
-        mockCalcs[CALCULATION_CODES.MEDIAN_BONUS_PAY_DIFF_W].value + '% less',
+        Math.round(mockCalcs[CALCULATION_CODES.MEDIAN_BONUS_PAY_DIFF_W].value) + '% less',
       );
     });
   });

diff --git a/backend/src/v1/services/report-service.ts b/backend/src/v1/services/report-service.ts
@@ -304,7 +304,7 @@ const reportServicePrivate = {
     }
     amountDollars = Math.round(amountDollars * 100) / 100;
     if (amountDollars < 1) {
-      return `${amountDollars * 100} cents`;
+      return `${Math.round(amountDollars * 100)} cents`;
     }
     return `$${amountDollars.toFixed(2)}`;
   },
@@ -784,21 +784,21 @@ const reportService = {
       ),
       medianOvertimePayGap: reportServicePrivate.getWageGapTextSummary(
         referenceGenderCode,
-        chartData.meanOvertimePayGap,
+        chartData.medianOvertimePayGap,
         'median',
         'overtime pay',
         false,
       ),
       meanBonusPayGap: reportServicePrivate.getWageGapTextSummary(
         referenceGenderCode,
-        chartData.meanOvertimePayGap,
+        chartData.meanBonusPayGap,
         'average',
         'bonus pay',
         false,
       ),
       medianBonusPayGap: reportServicePrivate.getWageGapTextSummary(
         referenceGenderCode,
-        chartData.meanOvertimePayGap,
+        chartData.medianBonusPayGap,
         'median',
         'bonus pay',
         false,