Gh authentication - recreating so it uses latest Helm bits in GitOps repo #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheaphillips
added
the
preview
|
MonicaG
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Hi @sheaphillips,
Looks good. I also looked at the code in the gitops repo as well. I think I have an understanding of how it works, and I think the changes you made looks right.
I think it would be helpful to document in the readme file here or in the gitops repo about how this work.
One minor thing regarding the Backstage GitHub app, we might want to update the homepage from localhost to something real so future people know what this is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.