Devx1435 Design tokens + improve card styles #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oomIRL
requested review from
sheaphillips,
MonicaG,
jenreiher-bcgov and
Shivanganii
jenreiher-bcgov
approved these changes
Jul 15, 2024
MonicaG
approved these changes
Jul 22, 2024
| main: '#FF5630', | ||
| light: '#FF8F73', | ||
| main: tokens.iconsColorDanger, | ||
| light: tokens.supportSurfaceColorDanger, | ||
| dark: '#DE350B', |
There was a problem hiding this comment.
Are there dark tokens that can be used here and the following code blocks vs the hex codes?
There was a problem hiding this comment.
@MonicaG Thanks!
Unfortunately, there aren't dark tokens for success/info/error, at least based on the figma document. There is a dark red "dangerButton.hover" token that could be used for "error.dark", but I opted to leave the those colors as is.
I can bring this up with Tyler Krys. Less hex codes sounds good to me!
oomIRL
removed
the
preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design tokens + Improved card styling
I added the design tokens package and integrated the tokens into the theme.
In most cases the switch to tokens is rather subtle. However, the tokens have a high contrast focus, promoting accessibility. This is most noticeable with icon coloring; icons are significantly darker. Additionally, focused user input fields such as search bars and drop downs also have a brighter border color.
I styled the homepage cards to resemble what we see on the BC gov Homepage
In an effort to appear more "brand" consistent with other bc gov sites, I also added some of the button and header styles.
Although the card styles are mostly a flat white style, the /create cards still have some light decoration. This is because the /create page has a white background, and the cards didn't offer much visual separation.
codewise
I pulled the HomePage cards out into their own component. I think logically separating these simplifies the organization of the codebase, since the rest of the HomePage will likely remain static, and the new HomePageCards component is in a better place to potentially transition into more dynamic content.
Preview branch here