-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowplow analytics plugin #149
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oomIRL - thank you for the walk through!
plugins/analytics-module-snowplow/src/apis/implementations/AnalyticsApi/SnowplowAnalytics.ts
Outdated
Show resolved
Hide resolved
plugins/analytics-module-snowplow/src/apis/implementations/AnalyticsApi/SnowplowAnalytics.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing blocking this, but a few questions! great job :D
Snowplow search tracking + switching existing tracking over to the analytics plugin.
Search events fire whenever search results are returned, so we get an event for nearly every keystroke.
To get around this there's some logic to only track the most recent search event after a debounce time has elapsed.
This value can be configured via the app-config. Although, right now it's coming from a default value in the analytics module.
I attempted to keep the tracking consistent with the prior method, but I have observed some changes:
previous click data
backstage click data
I've got a preview branch up here: https://f5ff48-developer-portal-dev-dprepo-pr-149-f5ff48-dev.apps.silver.devops.gov.bc.ca/
(I dropped the preview for the time being)