Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New component recaptcha #60

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

Ian-c-cameron
Copy link
Contributor

Please check if the PR fulfills these requirements:

  • After these changes, the app was run and still works as expected
  • Tests for these changes were added (if applicable)
  • All existing unit tests were run and still pass

Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):

New Component: Recaptcha
Integrates Google Recaptcha and validates using recaptcha-service

Additional Notes:

Copy link
Contributor

@harrymaynard-maximus harrymaynard-maximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change requested please.

src/components/Recaptcha.vue Outdated Show resolved Hide resolved
@harrymaynard-maximus
Copy link
Contributor

Also, question: does this version of library (which includes the "vue-recaptcha" package) work in OOP without adding "vue-recaptcha" as a dependency?

@harrymaynard-maximus
Copy link
Contributor

Can you also add a unit testing suite? As a minimum, we want to confirm that the component renders.

@Ian-c-cameron
Copy link
Contributor Author

Also, question: does this version of library (which includes the "vue-recaptcha" package) work in OOP without adding "vue-recaptcha" as a dependency?

I have tested linked to OOP, and it builds without any changes. I do not forsee any difference once the new version is published.

Copy link
Contributor

@harrymaynard-maximus harrymaynard-maximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a simple unit test to confirm that the component renders?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants