Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FORMS-1685 remove obsolete version attribute #1559

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WalterMoar
Copy link
Collaborator

@WalterMoar WalterMoar commented Dec 28, 2024

Description

When building the devcontainer a docker compose file is used. Running this file creates the following warning:

docker compose -f /workspaces/common-hosted-form-service/.devcontainer/chefs_local/docker-compose.yml down

WARN[0000] /workspaces/common-hosted-form-service/.devcontainer/chefs_local/docker-compose.yml: the attribute version is obsolete, it will be ignored, please remove it to avoid potential confusion

Acceptance Criteria

  • The warning no longer appears when the container is built

Type of Change

fix (a bug fix)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Comment on lines 40 to 41
- "-Dkeycloak.migration.strategy=OVERWRITE_EXISTING" No newline at end of file
- "-Dkeycloak.migration.strategy=OVERWRITE_EXISTING"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is a difference in how Prettier is applied. I'll see if I can standardize it so that we don't have this kind of churn in YAML files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant