Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update express for path-to-regexp vuln #1553

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

WalterMoar
Copy link
Collaborator

Description

The GitHub Dependabot process has created an alert for the path-to-regexp dependency. To path-to-regexp the requirements outlined in the Security Threat and Risk Assessment's (STRA) Statement of Acceptable Risks (SoAR), this vulnerability must be handled by updating the package version (or mitigated in some other way, if updating the package is not possible).
https://github.com/bcgov/common-hosted-form-service/security/dependabot/218

Acceptance Criteria

  • The dependency is updated to a version that does not have the vulnerability

Type of Change

fix (a bug fix)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

@WalterMoar WalterMoar force-pushed the fix/1678-path-to-regexp-vuln branch from 5dafac9 to 0f9f1bf Compare December 23, 2024 19:49
@WalterMoar WalterMoar marked this pull request as ready for review December 23, 2024 19:58
@WalterMoar WalterMoar merged commit 3422c45 into bcgov:main Dec 23, 2024
5 checks passed
@WalterMoar WalterMoar deleted the fix/1678-path-to-regexp-vuln branch December 23, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant