Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FORMS-1588 update node to v20 #1550

Closed
wants to merge 3 commits into from

Conversation

WalterMoar
Copy link
Collaborator

@WalterMoar WalterMoar commented Dec 17, 2024

Description

Node.js is how we run the JavaScript code that makes up the application. The version that we choose is in the “sweet spot” where it’s a long term support (LTS) version that is still maintained, but it isn’t be actively developed (fewer changes).

We use Node.js in three places:

  1. The running CHEFS application, frontend and backend, in the deployed PRs, dev, test, and prod
  2. The “devcontainers” used by developers to work on the application
  3. The GitHub Actions that are the Continuous Integration / Continuous Deployment (CI/CD) pipeline used to automatically build, test, and deploy the application

Type of Change

fix (a bug fix)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

@WalterMoar WalterMoar force-pushed the fix/1588-node-v20-update branch from 3e0d96d to 95a21b3 Compare December 18, 2024 00:06
@WalterMoar WalterMoar marked this pull request as ready for review December 18, 2024 00:09
@WalterMoar WalterMoar closed this Dec 18, 2024
@WalterMoar
Copy link
Collaborator Author

Closing this to reopen and see if the Node 18/20 issue with the tests goes away.

@WalterMoar WalterMoar deleted the fix/1588-node-v20-update branch December 23, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant