-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FORMS-1580 - Required Field Flag #1549
Open
RyanBirtch-aot
wants to merge
132
commits into
bcgov:main
Choose a base branch
from
RyanBirtch-aot:feat-map
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/common-hosted-form-service into component-skeleton
fixed Unknown Component Render issue
Map submission Data Submission Updated
console removed
fixes for marker appearing at geocoder search, replaced with popup
Added fix for popup bug
Changes to map settings form to enable line input
test: FORMS-1527 Cypress test scripts for both export and print temp…
Update for Map component include in form Designer
Sync with main branch
… also added preventing the deletion of pre-set features on the map
FORMS-1580 - Required Field Flag for Maps
RyanBirtch-aot
requested review from
abhilash-aot,
usingtechnology,
jasonchung1871 and
nimya-aot
December 17, 2024 23:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the Required flag into the form designer UI. Overloaded the existing formio implementation of isEmpty, which is what is checked when validating the required value. Also added a feature to prevent the user from deleting the default features added to the map by the form designer, as such deletions would interfere with the required flag as well as any limitations placed on the number of features added to the map
Type of Change
feat (a new feature)
Checklist
Further comments