Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FORMS-1640 - changes to CSS to Improve error message contrast for accessibility. #1548

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bhuvan-aot
Copy link
Collaborator

Description

Description of the Problem:
Currently, when mandatory fields are not filled and validation is triggered, the contrast between the background pink colour and red font is not high enough to meet accessibility requirements. See the example below where contrast checker software notes a fail vs a pass.
image
image

Proposed UX Solution:

Remove the pink background entirely or change its colour to transparent across the entire CHEFS product or specifically within the "form submitter" forms.

How it looks after the CSS changes.
image

Type of Change

fix (a bug fix)

style (change to code style/formatting)

This is a breaking change because it might
Removing padding could cause Text/content appearing misaligned compared to neighboring elements.

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant