Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FORMS-1661 - Update API Spec for Preferences Parameter Format #1542

Merged

Conversation

bhuvan-aot
Copy link
Collaborator

Description

The preference parameter in the API specification is currently formatted incorrectly as follows

image

This format should be updated to a valid JSON format.

{"minDate":"2020-12-17T08:00:00Z","maxDate":"2020-12-18T08:00:00Z","updatedMinDate":"2020-12-17T08:00:00Z","updatedMaxDate":"2020-12-18T08:00:00Z"}

Type of Change

docs (change to documentation)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Copy link
Collaborator

@WalterMoar WalterMoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix! It doesn't look like this has been deployed, so it can't be checked. But if it looks good in your local environment then go for it!

@bhuvan-aot
Copy link
Collaborator Author

Great fix! It doesn't look like this has been deployed, so it can't be checked. But if it looks good in your local environment then go for it!

not sure if any available pods for deployment, this is how it looks in my local.
image

@bhuvan-aot bhuvan-aot merged commit 5f75bc9 into bcgov:main Dec 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants