Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various vue3 css fixes #1079

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Conversation

WalterMoar
Copy link
Collaborator

@WalterMoar WalterMoar commented Oct 11, 2023

Description

  1. The list of components that can be added to a form should always be visible on a really long form. The changes to the names of Vuetify 3 CSS selectors broke this functionality.
    Before:
    image
    After:
    image

  1. The Team Management table was missing the class that the CSS selectors use. Also updated the CSS to use deep() instead of the deprecated >>> notation
    Before:
    image
    After:
    image

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

@WalterMoar WalterMoar marked this pull request as ready for review October 11, 2023 21:02
@jasonchung1871 jasonchung1871 merged commit c1cf8c3 into bcgov:vue3 Oct 11, 2023
@WalterMoar WalterMoar deleted the fix/vue3-css-fixes branch October 11, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants