FORMS-867: Export CSV submission columns issue (new validation for 'form' keyword in fieldnames) #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
Coverage Report (Frontend)
|
WalterMoar
requested changes
Sep 21, 2023
| @@ -529,6 +532,18 @@ export default { | |||
| this.addPatchToHistory(); | |||
| } | |||
| } | |||
| this.canSave = true; | |||
| modified?.components?.map((comp) => { | |||
| if (comp.key === 'form') { | |||
There was a problem hiding this comment.
My concern here is that it's a breaking change. A form that was fine before this PR will produce an error when edited and saved after this PR, even if there are no changes to the form.
Maybe this isn't a big deal - how hard would it be to identify how many forms already in production use "form" as one of the field names? Maybe we could work with those form owners to fix their forms before the change.
There was a problem hiding this comment.
@WalterMoar there are only 2 published forms which have form as a field name, should we just notify them?
WalterMoar
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to fix use cases when user would name one of the fields as
formwhich is system keyword, so we added additional validation so users can't use this API name for fieldsTypes of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments