Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: experimental tooltips timing delays #1030

Closed

Conversation

timisenco2015
Copy link
Contributor

@timisenco2015 timisenco2015 commented Sep 20, 2023

Description

Tooltip timing problems occur when the user transitions away from the tooltip content, but the tooltip itself remains visible for an additional 4 seconds

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

@github-actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 41.64% ( 2623 / 6299 )
Methods: 36.51% ( 318 / 871 )
Lines: 46.95% ( 1733 / 3691 )
Branches: 32.93% ( 572 / 1737 )

@github-actions
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 69.33% ( 1092 / 1575 )
Methods: 65.87% ( 193 / 293 )
Lines: 74.06% ( 768 / 1037 )
Branches: 53.47% ( 131 / 245 )

@WalterMoar
Copy link
Collaborator

WalterMoar commented Sep 21, 2023

It looks like the reason for those close-delay settings was to make it easier to click the links in the tooltips. In the deploy for this PR, it's fairly difficult to click the links because the tooltips now disappear when you try to move your mouse into them.

Is there any way to have the close-delay but have all other tooltips disappear when a new one is shown? If that's too difficult, then maybe a shorter delay would work?

Oh! I see. I will research how to close the open tooltip dynamically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants