-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FORMS-844: Add ability to subset submissions for export #1007
Conversation
Release 48b97d8 deployed at https://chefs-dev.apps.silver.devops.gov.bc.ca/pr-1007 |
@@ -125,6 +126,7 @@ export default { | |||
isRTL: (state) => state.isRTL, | |||
subscriptionData: (state) => state.subscriptionData, | |||
totalSubmissions: (state) => state.totalSubmissions, | |||
selectedSubmissions: (state) => state.selectedSubmissions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to start improving the code coverage of the unit tests. Can you check the coverage reports in the actions (or run the tests locally and check app/frontend/coverage/lcov-report/index.html and app/coverage/lcov-report/index.html) to make sure there are tests for anything that is added?
(Although a lot of the tests are fairly simple and don't add a lot of value, it'll make it easier to identify missing coverage if we follow what the original team did for tests)
I think one of the problems we're going to have is that if I have v1 and v2 submissions, I can't tell from the submissions table that they're different versions. So if I select submissions from different versions, and then choose a CSV export, not all of the submissions I selected will be exported. |
Maybe a question for Jordan and Manadir, but maybe a new feature would be to remove the "Version" dropdown (or allow it to be multiselect) and download a .zip file of CSVs if there are multiple versions? Just a wild idea! |
agreed, Manadir and Jordan should be involved here |
@WalterMoar actually, I thought it might be a good idea to not even filter by version if selected submission ids specified, so it'd more convenient for users, they select needed submissions from the list and expect all of them to be imported no matter what version they belong to, what do you think? |
…mmon-hosted-form-service into FORMS-844-subset-export
Closing this - I think we need to look at redesigning the whole CSV export. |
Description
Requested By (and initially reported as a UX bug via)
As a CHEFS stakeholder, I need to be able to
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments