Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORMS-844: Add ability to subset submissions for export #1007

Closed
wants to merge 8 commits into from

Conversation

bcvesalink
Copy link
Contributor

Description

Requested By (and initially reported as a UX bug via)
As a CHEFS stakeholder, I need to be able to

  • define a subset of submissions for a given form version
  • export that subset of submissions to a CSV-formatted file

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

@bcvesalink bcvesalink self-assigned this Sep 14, 2023
@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Coverage Report (Frontend)

Totals Coverage
Statements: 67.83% ( 1107 / 1632 )
Methods: 64.82% ( 199 / 307 )
Lines: 72.04% ( 778 / 1080 )
Branches: 53.06% ( 130 / 245 )

@github-actions
Copy link

github-actions bot commented Sep 14, 2023

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Coverage Report (Application)

Totals Coverage
Statements: 41.83% ( 2636 / 6301 )
Methods: 36.79% ( 326 / 886 )
Lines: 47.41% ( 1759 / 3710 )
Branches: 32.32% ( 551 / 1705 )

@bcvesalink bcvesalink changed the title feat: add ability to subset submissions for export FORMS-844: Add ability to subset submissions for export Sep 19, 2023
@@ -125,6 +126,7 @@ export default {
isRTL: (state) => state.isRTL,
subscriptionData: (state) => state.subscriptionData,
totalSubmissions: (state) => state.totalSubmissions,
selectedSubmissions: (state) => state.selectedSubmissions,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to start improving the code coverage of the unit tests. Can you check the coverage reports in the actions (or run the tests locally and check app/frontend/coverage/lcov-report/index.html and app/coverage/lcov-report/index.html) to make sure there are tests for anything that is added?

(Although a lot of the tests are fairly simple and don't add a lot of value, it'll make it easier to identify missing coverage if we follow what the original team did for tests)

@WalterMoar
Copy link
Collaborator

I think one of the problems we're going to have is that if I have v1 and v2 submissions, I can't tell from the submissions table that they're different versions. So if I select submissions from different versions, and then choose a CSV export, not all of the submissions I selected will be exported.

@WalterMoar
Copy link
Collaborator

I think one of the problems we're going to have is that if I have v1 and v2 submissions, I can't tell from the submissions table that they're different versions. So if I select submissions from different versions, and then choose a CSV export, not all of the submissions I selected will be exported.

Maybe a question for Jordan and Manadir, but maybe a new feature would be to remove the "Version" dropdown (or allow it to be multiselect) and download a .zip file of CSVs if there are multiple versions? Just a wild idea!

@bcvesalink
Copy link
Contributor Author

I think one of the problems we're going to have is that if I have v1 and v2 submissions, I can't tell from the submissions table that they're different versions. So if I select submissions from different versions, and then choose a CSV export, not all of the submissions I selected will be exported.

Maybe a question for Jordan and Manadir, but maybe a new feature would be to remove the "Version" dropdown (or allow it to be multiselect) and download a .zip file of CSVs if there are multiple versions? Just a wild idea!

agreed, Manadir and Jordan should be involved here

@bcvesalink
Copy link
Contributor Author

I think one of the problems we're going to have is that if I have v1 and v2 submissions, I can't tell from the submissions table that they're different versions. So if I select submissions from different versions, and then choose a CSV export, not all of the submissions I selected will be exported.

Maybe a question for Jordan and Manadir, but maybe a new feature would be to remove the "Version" dropdown (or allow it to be multiselect) and download a .zip file of CSVs if there are multiple versions? Just a wild idea!

@WalterMoar actually, I thought it might be a good idea to not even filter by version if selected submission ids specified, so it'd more convenient for users, they select needed submissions from the list and expect all of them to be imported no matter what version they belong to, what do you think?

@WalterMoar
Copy link
Collaborator

Closing this - I think we need to look at redesigning the whole CSV export.

@WalterMoar WalterMoar closed this Jan 3, 2024
@WalterMoar WalterMoar deleted the FORMS-844-subset-export branch January 3, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants