Security updates #34
Merged
Security updates #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatindersingh93
force-pushed
the
SC3520
branch
2 times, most recently
from
3c7cdf7 to
98123cd
Compare
|
The app seems to be functioning fine on the current deployment from commit 98123cd |
Coverage Report (Application)
|
Coverage Report (Frontend)
|
jatindersingh93
force-pushed
the
SC3520
branch
7 times, most recently
from
dbfbaab to
da11092
Compare
TimCsaky
reviewed
Apr 5, 2024
app/frontend/package.json
Outdated
There was a problem hiding this comment.
Would be good to indent the first level to show a clearer diff of the packages
app/frontend/src/App.vue
Outdated
| @@ -14,15 +14,21 @@ | |||
| </template> | |||
|
|
|||
| <script> | |||
| // eslint-disable-next-line vue/no-reserved-component-names | |||
There was a problem hiding this comment.
i dont think we need all these instructions telling eslint to ignore in this file.
I had them in the other repo because the components were named Header and Footer which are reserved names.
Where here they are BCGovHeader and BCGovFoter.
Could try removing.
jatindersingh93
force-pushed
the
SC3520
branch
5 times, most recently
from
dfd94f0 to
1723b22
Compare
TimCsaky
approved these changes
Apr 10, 2024
wilwong89
approved these changes
Apr 10, 2024
norrisng-bc
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
Checklist
Further comments