Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing namespace config value in GA Helm deploy argument command #98

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Add missing namespace config value in GA Helm deploy argument command #98

merged 1 commit into from
Nov 14, 2023

Conversation

jujaga
Copy link
Member

@jujaga jujaga commented Nov 14, 2023

Description

SHOWCASE-3398

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the OpenAPI 3.0 v*.api-spec.yaml documentation (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

@jujaga jujaga added bug Something isn't working devops labels Nov 14, 2023
@jujaga jujaga requested a review from TimCsaky November 14, 2023 19:25
@jujaga jujaga self-assigned this Nov 14, 2023
@jujaga jujaga marked this pull request as ready for review November 14, 2023 19:25
@github-actions GitHub Actions
Copy link

Coverage Report

Totals Coverage
Statements: 13.04% ( 118 / 905 )
Methods: 20.83% ( 15 / 72 )
Lines: 12.17% ( 69 / 567 )
Branches: 12.78% ( 34 / 266 )

@TimCsaky TimCsaky merged commit f23b82b into master Nov 14, 2023
12 checks passed
@TimCsaky TimCsaky deleted the bugfix/namespaceparam branch November 14, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimCsaky TimCsaky TimCsaky approved these changes

Assignees

@jujaga jujaga

Labels
bug Something isn't working devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jujaga @TimCsaky