Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDOGS Helm Chart and associated GA workflow #96

Merged
merged 3 commits into from
Nov 11, 2023
Merged

Conversation

jujaga
Copy link
Member

@jujaga jujaga commented Nov 10, 2023

Description

This PR introduces the CDOGS Helm Chart with optional fluent-bit sidecar support as well as the associated Github Action to begin automating chart releases.

SHOWCASE-3398

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the OpenAPI 3.0 v*.api-spec.yaml documentation (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

Note that Jenkins is now flipped off as of this PR.

@jujaga jujaga added documentation Improvements or additions to documentation enhancement New feature or request devops labels Nov 10, 2023
@jujaga jujaga self-assigned this Nov 10, 2023
Copy link

Coverage Report

Totals Coverage
Statements: 13.04% ( 118 / 905 )
Methods: 20.83% ( 15 / 72 )
Lines: 12.17% ( 69 / 567 )
Branches: 12.78% ( 34 / 266 )

@@ -3,18 +3,22 @@ config:
enabled: true
configMap:
KC_ENABLED: "true"
KC_PUBLICKEY: ~
KC_PUBLICKEY: >-
MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAtq5+xTKB1FRCwufdluEx8mNIZU3eXpo91QUrqlpq226HcyF9WPihdpuZzdlS+kW6EC2prZfJpvDvzT/Og4fx9ZoQVKV0uYvWvEg5Sc3ikQMfO0ngqUC6FkxElj9LzpijpdEQd0JAmmem2329lITwWroX70imLhYu3aY+Q3hSY2lg5OJCBw0I2pulfQiMsGn3vgkwSvmIsDhOgSnwPJhPxD9TY6kjvTff6LB1bFSwlxh1l8dRBqRabDunoHn/uHfhVAHB/SgPkvP5Ybc5bP/idBNP0kiQcWiT02Z7aB1r7Fnd5YH9FEDhhF5OIYYBzHP4hPm6AgqG/IDhAuiqf/F9eQIDAQAB

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering about adding publickey to the repo, is there any specific reason?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is publicly known and accessible information. This key is used to verify the signature of the incoming JWT tokens that it was generated by the right provider.

@wilwong89 wilwong89 merged commit 69c8c16 into master Nov 11, 2023
11 checks passed
@wilwong89 wilwong89 deleted the ci/sidecar branch November 11, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants