Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node base image, bcgovpubcode and test pipelines #91

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

jujaga
Copy link
Member

@jujaga jujaga commented Oct 20, 2023

Description

This is a minor maintenance PR aiming at bringing CDOGS up to date with the latest node version. It also does a bit of behind the scenes maintenance by updating the test pipeline as well as adding in the bcgovpubcode manifest.

SHOWCASE-3195

Types of changes

Bug fix (non-breaking change which fixes an issue)

Documentation (non-breaking change with enhancements to documentation)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the OpenAPI 3.0 v*.api-spec.yaml documentation (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

@jujaga jujaga added bug Something isn't working documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file devops labels Oct 20, 2023
@jujaga jujaga self-assigned this Oct 20, 2023
@jujaga jujaga force-pushed the chore/maintenance branch from 8cff6e3 to ea361e4 Compare October 20, 2023 19:58
@jujaga jujaga force-pushed the chore/maintenance branch from ea361e4 to 0ae2cf3 Compare October 20, 2023 20:07
@ghost
Copy link

ghost commented Oct 20, 2023

Copy link
Contributor

@TimCsaky TimCsaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can update bcgovbupcode details later if required

@jujaga jujaga force-pushed the chore/maintenance branch from 0ae2cf3 to 92a1095 Compare October 20, 2023 20:23
@TimCsaky TimCsaky merged commit cf09116 into bcgov:master Oct 20, 2023
6 checks passed
@jujaga jujaga deleted the chore/maintenance branch October 20, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file devops documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants