Change build strategy to support PDF conversion via LibreOffice #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy Ho <[email protected]>
Change content type to pdf if pdf Signed-off-by: Jeremy Ho <[email protected]>
Add in work in progress working Dockerfile Simplify temp file extension handling Signed-off-by: Jeremy Ho <[email protected]>
Signed-off-by: Jeremy Ho <[email protected]>
jujaga
force-pushed
the
feature/libreoffice
branch
2 times, most recently
from
b694071 to
5b9907b
Compare
Collapse Dockerfile into app.bc.yaml Update openshift template indentations Signed-off-by: Jeremy Ho <[email protected]>
jujaga
force-pushed
the
feature/libreoffice
branch
from
5b9907b to
24182e2
Compare
jujaga
changed the title
Add notes on the build config Docker strategy Signed-off-by: Jeremy Ho <[email protected]>
Signed-off-by: Jeremy Ho <[email protected]>
usingtechnology
suggested changes
Dec 21, 2019
loneil
reviewed
Dec 21, 2019
Drop unused nodejs:10 ImageStream from buildconfig Signed-off-by: Jeremy Ho <[email protected]>
jujaga
commented
Dec 21, 2019
jujaga
force-pushed
the
feature/libreoffice
branch
from
c9c76f4 to
00b1778
Compare
usingtechnology
approved these changes
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on enabling the PDF conversion capability in the Carbone.js library. To this end, the core change involves us switching out from an S2I build to a custom Alpine image with the addition of LibreOffice components to allow PDF conversion to happen.
We switch off of S2I to an Alpine image in order to have more control over the build process, as well as have a leaner docker image. While S2I is capable of handling standard node applications, the addition of LibreOffice introduces another layer of complexity that S2I honestly wasn't designed to handle.
For reference, the proposed Alpine image is ~700MB in size, whereas an equivalent build extending from the S2I image would be ~2.1GB in size.
[SHOWCASE-405]
[SHOWCASE-455]
Types of changes
New feature (non-breaking change which adds functionality)
Documentation (non-breaking change with enhancements to documentation)
Checklist
v*.api-spec.yamldocumentation (if appropriate)Further comments
Related Issues: carboneio/carbone#46