Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security updates: Node v20.15.1 and npm dependencies #111

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

norrisng-bc
Copy link
Contributor

Description

  • Update npm dependencies
  • Update Node to latest LTS version as of writing (v20.15.1)
  • Update CODEOWNERS file to reflect change in team members

The alpine-node-libreoffice image was also updated separately to enable the Node update in here

https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3619

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the OpenAPI 3.0 v*.api-spec.yaml documentation (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

eslint is out of date, but it was not updated as part of this PR.

Linter rules are currently defined inside package.json - this is no longer the default behaviour as of v9.0.0 (it can be reverted by setting the environment variable ESLINT_USE_FLAT_CONFIG to true though) and will be removed entirely in v10.0.0.

https://eslint.org/blog/2024/04/eslint-v9.0.0-released/#flat-config-is-now-the-default-and-has-some-changes

Copy link

Coverage Report

Totals Coverage
Statements: 16.04% ( 140 / 873 )
Methods: 25.71% ( 18 / 70 )
Lines: 15.33% ( 82 / 535 )
Branches: 14.93% ( 40 / 268 )

@norrisng-bc norrisng-bc changed the title Security updates Security updates: Node v20.15.1 and npm dependencies Jul 15, 2024
@norrisng-bc norrisng-bc requested a review from TimCsaky July 15, 2024 23:01
@TimCsaky TimCsaky merged commit 337b1c2 into master Jul 16, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants