Swap out keycloak-connect for jsonwebtoken for JWT authentication #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
TimCsaky
reviewed
Apr 22, 2024
norrisng-bc
force-pushed
the
chore/drop-keycloak-connect
branch
3 times, most recently
from
3a44388 to
46e2c5b
Compare
Implementation taken from COMS
norrisng-bc
force-pushed
the
chore/drop-keycloak-connect
branch
from
46e2c5b to
fb57163
Compare
TimCsaky
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JWT validation was previously handled by the
keycloak-connectpackage. This PR replaces thekeycloak-connect-based implementation with one usingjsonwebtoken.keycloak-connecthas been deprecated since 2022.In addition, authentication errors now return a HTTP 401 instead of a HTTP 500. A detailed error message was already present in the 500, but nonetheless it's still better to return an actual 401 instead.
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3576
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
v*.api-spec.yamldocumentation (if appropriate)Further comments
The
jsonwebtoken-based implementation was ported over from COMS.Authentication-related config variables, if set to
false, are now read correctly. This bugfix was also ported over from COMS (see bcgov/common-object-management-service#245)