Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Keycloak config optional and update docs #104

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

TimCsaky
Copy link
Contributor

Description

ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3471

  • update readme with correct template cache default
  • update keycloak component so keycloak config is all optional (dependednt on whether keycloak is enabled)

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the OpenAPI 3.0 v*.api-spec.yaml documentation (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

Coverage Report

Totals Coverage
Statements: 16.11% ( 139 / 863 )
Methods: 26.47% ( 18 / 68 )
Lines: 15.43% ( 81 / 525 )
Branches: 14.81% ( 40 / 270 )

@TimCsaky TimCsaky changed the title Bug/config defaults make Keycloak config optional and update docs Jan 12, 2024
@jujaga jujaga changed the title make Keycloak config optional and update docs Make Keycloak config optional and update docs Jan 12, 2024
@kyle1morel kyle1morel merged commit 651b856 into master Jan 12, 2024
15 of 16 checks passed
@kyle1morel kyle1morel deleted the bug/config-defaults branch January 12, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants