Implement support for automated cache pruning maintenance #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were writing transient files into the PVC cache save directory, which fundamentally does not make sense as it may not necessarily make its way into the cache. By writing it into the temp directory, we can alleviate some PVC space pressure in the containers. Signed-off-by: Jeremy Ho <[email protected]>
Signed-off-by: Jeremy Ho <[email protected]>
Signed-off-by: Jeremy Ho <[email protected]>
By default, the cronJob will be enabled for all deployments and attempt to keep the specified cache directory no more than 80% full twice a week. This can be disabled as usual via Helm value overrides. Signed-off-by: Jeremy Ho <[email protected]>
jujaga
requested review from
jatindersingh93,
wilwong89,
TimCsaky,
norrisng-bc and
kyle1morel
jujaga
changed the title
Coverage Report
|
TimCsaky
approved these changes
Nov 27, 2023
kyle1morel
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on filling in the maintenance gap of keeping a cache directory within a specified space limit. This is important for ensuring that PVCs do not become full during the runtime of the application. It will come with the following scheduling defaults and behaviors:
Commits:
SHOWCASE-3332
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Checklist
v*.api-spec.yamldocumentation (if appropriate)Further comments