Remove Cache Report and v1 Endpoints #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy Ho <[email protected]>
Signed-off-by: Jeremy Ho <[email protected]>
Signed-off-by: Jeremy Ho <[email protected]>
Saving rendered template outputs was never a part of the original CDOGS design, and could potentially yield privacy issues. This commit drops the ability to request caching resultant reports. Signed-off-by: Jeremy Ho <[email protected]>
This code has been unused for years and likely will never be used again. Signed-off-by: Jeremy Ho <[email protected]>
jujaga
requested review from
jatindersingh93,
wilwong89,
TimCsaky,
norrisng-bc and
kyle1morel
Coverage Report
|
wilwong89
approved these changes
Nov 21, 2023
These values are useful for determing what instance of the CDOGS codebase is running for diagnostic and debugging purposes. Signed-off-by: Jeremy Ho <[email protected]>
norrisng-bc
approved these changes
Nov 21, 2023
…rets There was a bug where the only way to ensure keycloak authentication was enabled was to have config.configMap.KC_ENABLED defined, even when we are not wanting to generate our own release-scoped config map. This fix adds in a feature toggle to declare authentication mode intent independent of the configuration. Signed-off-by: Jeremy Ho <[email protected]>
TimCsaky
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on closing out a potential vector for private information storage by dropping the report caching functionality. It also implements a minor bugfix for PR deployments which should be reflected in subsequent PRs.
Types of changes
Documentation (non-breaking change with enhancements to documentation)
Breaking change (fix or feature that would cause existing functionality to change)
Checklist
v*.api-spec.yamldocumentation (if appropriate)Further comments