Merge pull request #89 from TimCsaky/api-gateway

Api gateway
bcgov · Oct 26, 2022 · 26d3052 · 26d3052
2 parents b0995ba + 2e3477d
commit 26d3052
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/app/src/components/keycloak.js b/app/src/components/keycloak.js
@@ -11,6 +11,6 @@ module.exports = new Keycloak({}, {
   secret: config.has('keycloak.clientSecret') ? config.get('keycloak.clientSecret') : undefined,
   serverUrl: config.get('keycloak.serverUrl'),
   'ssl-required': 'external',
-  'use-resource-role-mappings': true,
+  'use-resource-role-mappings': false,
   'verify-token-audience': true
 });
diff --git a/app/src/docs/v1.api-spec.yaml b/app/src/docs/v1.api-spec.yaml
@@ -87,9 +87,6 @@ paths:
       operationId: postDocGen
       tags:
         - DocGen
-      security:
-        - OpenID:
-            - GENERATOR
       requestBody:
         description: Fields required to generate a document
         required: true

diff --git a/app/src/docs/v2.api-spec.yaml b/app/src/docs/v2.api-spec.yaml
@@ -141,7 +141,8 @@ paths:
               type: object
               properties:
                 template:
-                  type: binary
+                  type: string
+                  format: binary
       responses:
         "200":
           description: Returns the supplied document with variables merged in

diff --git a/app/src/routes/v1/index.js b/app/src/routes/v1/index.js
@@ -1,4 +1,3 @@
-const config = require('config');
 const router = require('express').Router();
 
 const docGenRouter = require('./docGen');
@@ -8,7 +7,6 @@ const healthRouter = require('./health');
 const { protect } = require('../../middleware/authorization');
 const { getDocs, getJsonSpec, getYamlSpec } = require('../../middleware/openapi');
 
-const clientId = config.has('keycloak.enabled') ? config.get('keycloak.clientId') : '';
 const version = 'v1';
 
 /** Base Responder */
@@ -35,7 +33,7 @@ router.get('/api-spec.yaml', getYamlSpec(version));
 router.get('/docs', getDocs(version));
 
 /** Doc Gen Router */
-router.use('/docGen', protect(`${clientId}:GENERATOR`), docGenRouter);
+router.use('/docGen', protect(), docGenRouter);
 
 /** File Types Router */
 router.use('/fileTypes', protect(), fileTypesRouter);