Skip to content

Commit

Permalink
Merge pull request #72 from bcgov/chore/define-max-body-size
Browse files Browse the repository at this point in the history
Chore: define max body size
  • Loading branch information
dleard authored May 12, 2023
2 parents 3b65356 + cd7dd85 commit cdd4bb2
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-nginx-on-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Get the tag name
id: get_tag_name
run: echo ::set-output name=CHART_VERSION::${GITHUB_REF/refs\/tags\/nginx-sidecar-/}
- uses: RafikFarhad/push-to-gcr-github-action@v3.0.2
- uses: RafikFarhad/push-to-gcr-github-action@v4.1.0
with:
gcloud_service_key: ${{ secrets.GCR_KEY }}
project_id: ggl-cas-storage
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-nginx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: RafikFarhad/push-to-gcr-github-action@v3.0.2
- uses: RafikFarhad/push-to-gcr-github-action@v4.1.0
with:
gcloud_service_key: ${{ secrets.GCR_KEY }}
project_id: ggl-cas-storage
Expand Down
2 changes: 1 addition & 1 deletion nginx-sidecar/helm/nginx-sidecar/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ name: nginx-sidecar
description: A helm chart that can be used to inject an nginx sidecar pod to handle SSL termination

type: application
version: 0.1.11
version: 0.1.12
appVersion: "1.20.1"
3 changes: 3 additions & 0 deletions nginx-sidecar/helm/nginx-sidecar/templates/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ metadata:
labels: {{ include "nginx-sidecar.labels" . | nindent 4 }}
data:
default.conf: |
{{- if .Values.clientMaxBodySize }}
client_max_body_size {{ .Values.clientMaxBodySize }};
{{- end }}
server {
{{- if .Values.sslTermination }}
listen {{ .Values.port }} ssl;
Expand Down
3 changes: 3 additions & 0 deletions nginx-sidecar/helm/nginx-sidecar/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@ hostName: "example-climate-action-secretariat.gov.bc.ca"
internalPort: ~
# Exposed to the outside
port: ~

# If provided, sets the maximum size of file uploads. Otherwise defaults to 1M.
clientMaxBodySize: ~

0 comments on commit cdd4bb2

Please sign in to comment.