chore: remove double counting of reporting-only emissions in compliance summary service #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatchpole
approved these changes
Dec 20, 2024
dleard
force-pushed
the
chore/compliance-summary-discrepancy
branch
from
58220d9 to
5640ad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compliance summary was considering emissions from all emission categories when calculating the total allocated, but should have been only considering basic categories. This was highlighted by manual testing of expected values vs what the app is calculating, finding a .02% difference in the credited emissions.
After the work in this PR, the expected values from manual calculations vs the app show a .00000004% difference in credited emissions when using the same values. This can be attributed to slight differences in rounding after the 4th decimal point, which will be handled later pending a BA decision around precision.
Card: bcgov/cas-reporting#474