Chore/431 allocation tests #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shon-button
force-pushed
the
chore/431-allocation-tests
branch
from
2761dbb to
33397bd
Compare
dleard
reviewed
Dec 24, 2024
| product_id=29, # "Sugar: solid" | ||
| ) | ||
|
|
||
| self.mock_get_response = { |
There was a problem hiding this comment.
@Sepehr-Sobhani @pbastia any thoughts on ways we could possibly cut down on the size of the mocked get repsonse / post payloads in this file? This service returns/ingests a pretty large object
There was a problem hiding this comment.
maybe a class or function to generate the data objects not being tested (ie: where allocated emissions are 0)?
There was a problem hiding this comment.
@dleard I think this is something that will be improved when we decouple the service return types from the API schemas. Using the API data types here forces us to use those large JSON objects, whereas we could use data structures much simpler or easy to manipulate for the service use case
acatchpole
force-pushed
the
chore/431-allocation-tests
branch
from
391d031 to
f5fdf69
Compare
dleard
approved these changes
Dec 31, 2024
acatchpole
force-pushed
the
chore/431-allocation-tests
branch
4 times, most recently
from
a540261 to
5c0d345
Compare
acatchpole
force-pushed
the
chore/431-allocation-tests
branch
from
5c0d345 to
c3e5ae7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend and Backend tests for Allocation of Emissions