Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump nanoid from 3.3.7 to 3.3.8 in /bciers #2596

Merged
merged 5 commits into from
Dec 27, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 14, 2024

Bumps nanoid from 3.3.7 to 3.3.8.

Changelog

Sourced from nanoid's changelog.

3.3.8

  • Fixed a way to break Nano ID by passing non-integer size (by @​myndzi).
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added Dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 14, 2024
@andrea-williams andrea-williams force-pushed the dependabot/npm_and_yarn/bciers/nanoid-3.3.8 branch 4 times, most recently from a21cb63 to e090316 Compare December 17, 2024 22:06
@dleard
Copy link
Contributor

dleard commented Dec 20, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 20, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@Sepehr-Sobhani Sepehr-Sobhani force-pushed the dependabot/npm_and_yarn/bciers/nanoid-3.3.8 branch from 5c81cd6 to c6c7ca1 Compare December 24, 2024 19:25
@Sepehr-Sobhani
Copy link
Contributor

@dleard Something is wrong with our e2e CI check! It is failing due to a change in this PR: #2620
But it was passing when I merged it.

@Sepehr-Sobhani
Copy link
Contributor

Sepehr-Sobhani commented Dec 27, 2024

@dleard Something is wrong with our e2e CI check! It is failing due to a change in this PR: #2620 But it was passing when I merged it.

@dleard Found the issue. Here we run the e2e test conditionally based on the is_nx_affected flag, which checks whether we've changed any part of the code in the frontend app. However, the PR that I mentioned changed some backend fixtures, causing this issue.

Created a task ticket here: #2641
(not sure if this is a task or bug or tech debt 😃 )

@Sepehr-Sobhani Sepehr-Sobhani force-pushed the dependabot/npm_and_yarn/bciers/nanoid-3.3.8 branch from f643f44 to feb298a Compare December 27, 2024 18:14
@Sepehr-Sobhani Sepehr-Sobhani merged commit 7deb1a8 into develop Dec 27, 2024
42 checks passed
@Sepehr-Sobhani Sepehr-Sobhani deleted the dependabot/npm_and_yarn/bciers/nanoid-3.3.8 branch December 27, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants