chore: apply suggestions from code review

bcgov · Dec 24, 2024 · 220956b · 220956b
1 parent ab96e94
commit 220956b
Show file tree

Hide file tree

Showing 10 changed files with 9 additions and 892 deletions.
diff --git a/bc_obps/Makefile b/bc_obps/Makefile
@@ -92,7 +92,7 @@ superuser: ## create a superuser
 superuser:
 	$(POETRY_RUN) python $(MANAGE_PY) create_superuser
 
-loadfixtures_v1: ## add all registration fixture files to the db
+loadfixtures_v1: ## add all registration v1 fixture files to the db
 loadfixtures_v1:
 	$(POETRY_RUN) python $(MANAGE_PY) load_fixtures_v1 $(ARGS)
 	$(POETRY_RUN) python $(MANAGE_PY) load_reporting_fixtures $(ARGS)

diff --git a/bc_obps/common/management/commands/load_fixtures_v1.py b/bc_obps/common/management/commands/load_fixtures_v1.py
@@ -21,13 +21,6 @@ def handle(self, *args, **options):
             f'{fixture_base_dir}/multiple_operator.json',
             f'{fixture_base_dir}/document.json',
             f'{fixture_base_dir}/user_operator.json',
-            f'{fixture_base_dir}/facility.json',
-            f'{fixture_base_dir}/facility_designated_operation_timeline.json',
-            f'{fixture_base_dir}/operation_designated_operator_timeline.json',
-            f'{fixture_base_dir}/restart_event.json',
-            f'{fixture_base_dir}/closure_event.json',
-            f'{fixture_base_dir}/temporary_shutdown_event.json',
-            f'{fixture_base_dir}/transfer_event.json',
             f'{fixture_base_dir}/parent_operator.json',
             f'{fixture_base_dir}/partner_operator.json',
         ]

diff --git a/bc_obps/registration/fixtures/mock/v1/closure_event.json b/bc_obps/registration/fixtures/mock/v1/closure_event.json
diff --git a/bc_obps/registration/fixtures/mock/v1/facility.json b/bc_obps/registration/fixtures/mock/v1/facility.json