-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/1333 replace terraform cloud #1887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! A few comments about bash formatting, looks good otherwise.
I'd suggest also:
- moving
tf-migration.sh
andmigration.example.tfvars
out of the helm chart, I don't think there is a to have these in there? - move all the terraform yaml templates to
chart/cas-cif/templates/terraform
instead of thejobs
folder
I cleaned up the directories with the suggestions you made. Especially with the service account related file split, it keeps them consistently together. I removed the migration script entirely, as it is unneeded now that the migrations have been run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slick!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff! Leaving it Approved but not merged as per discussion today about merging with eyes on. Aside from that let's make sure we get a tech-debt card to create custom GCP role instead of their generic admin, they over permit.
Great stuff!
81e5697
to
76ea17b
Compare
Addresses #1333 - Project link
Adds Terraform scripts and Helm charts to run them. Resource states migrated from Terraform Cloud to a Google Cloud Storage bucket.
Changes 🚧
To test 🔬
Terraform-apply
in OpenShift to see if the run was successful.Notes📝
kubernetes_secret.secret_sa
have had Terraform changes, but only the addition of a default value (consistent with our use of them) due to a new provider version.