Code

Chore/1876 rebase pending revisions#1882

Code

Merged

mikevespi merged 51 commits intodevelopbcgov/cas-cif:developfrom chore/1876-rebase-pending-revisionsbcgov/cas-cif:chore/1876-rebase-pending-revisionsCopy head branch name to clipboardApr 8, 2024

+1,615-28

Commits

Commits on Apr 2, 2024

• chore: add jsonb minus

  mikevespi

  committed
  52baf12

• chore: rework setup for commit_form_change_internal

  mikevespi

  committed
  39b47cd

• chore: pass correct arguments to commit form change internal

  mikevespi

  committed
  921f579

• chore: rebase changes made in pending form change on top of the committing form change

  mikevespi

  committed
  983ad50

• chore: handle the merging of form changes when another project revision is pending on the project

  mikevespi

  committed
  34c77b9

• test: initial tests for concurrent revisions merging

  mikevespi

  committed
  9e5ee2f

• test: test the updates of the simple forms in commit_form_change_internal

  mikevespi

  committed
  52e2301

• chore: fix revert sqitch function

  mikevespi

  committed
  6a1bcad

• chore: fix signature in rever

  mikevespi

  committed
  371807f

• chore: explicitly drop the old function signature

  mikevespi

  committed
  ac8c74d

• test: add create and mutual update tests

  mikevespi

  committed
  e83dfee

• chore: explicitly drop other function signature in revert file

  mikevespi

  committed
  29afc50

• chore: fix db deploy

  mikevespi

  committed
  d4d974e

• chore: switch test check from form change to project table, fc tested elsewhere

  mikevespi

  committed
  d8f52b0

• test: explicit argument list in function should exist test

  mikevespi

  committed
  bbddafc

• test: typecast values in test resturn

  mikevespi

  committed
  e461f80

• chore: fix quotes in pg test

  mikevespi

  committed
  1723f74

• chore: handle the new commit_form_change_internal args in commit_form_change

  mikevespi

  committed
  c51a4c3

• test: test the case when the commiting fc has made changes but the pending has not

  mikevespi

  committed
  1b0669b

• test: test that attachments are handled correctly when concurrent revisions are committed

  mikevespi

  committed
  8527c05

• chore: set the previous_form_change_id on pending form changes

  mikevespi

  committed
  c23fe07

• test: check previous_form_change_id and form_data_record_id on create operations

  mikevespi

  committed
  a16a838

• test: add separate test for checking create on contacts

  mikevespi

  committed
  5739bdf

• chore: handle the various cases for creating form changes in concurrent revisions, untested

  mikevespi

  committed
  df054fb

• chore: remove unnecessary comment

  mikevespi

  committed
  f26b393

• test: cleanup assertions and add testing for creating a funding agreement

  mikevespi

  committed
  d7f47ed

• chore: cast incremented indices in form data back to jsonb

  mikevespi

  committed
  8ecb312

• test: prep for the restof the create tests

  mikevespi

  committed
  34cada4

• test: add contacts to use as managers

  mikevespi

  committed
  6ad612d

• docs: add start of concurrent revision handling documentation

  mikevespi

  committed
  e1152b0

• docs: update concurrent revision doc

  mikevespi

  committed
  d99a18e

• chore: address PR comments

  mikevespi

  committed
  68b0b93

• chore: set the operation of pending form changes to update when committing creates them

  mikevespi

  committed
  ee1108e

• test: add tests for adding project_managers with pending revision

  mikevespi

  committed
  15e9846

• test: tests for adding reporting requirements in both committing and pending form changes

  mikevespi

  committed
  fd25539

• chore: fix update previous_form_change_id scope in commit_form_change_internal

  mikevespi

  committed
  90550cf

• chore: remove redundant limit 1

  mikevespi

  committed
  ef243d8

• chore: added comments for clarity

  mikevespi

  committed
  f9d8947

• chore: updated function comment to be more accurate

  mikevespi

  committed
  bf476bf

• test: update the milestone concurrent revision tests

  mikevespi

  committed
  c728566

• test: move concurrent revision tests to a separate file and add contact tests to them

  mikevespi

  committed
  bb2240f

• test: add directory of tests related to concurrent revisions and update the tests

  mikevespi

  committed
  3a96df5

• chore: when committing archives something that pending has updated change pendings operation to create and null the record id and previous form change

  mikevespi

  committed
  c69066b

• chore: remove test file that whose tests have been distributed to more specific test files

  mikevespi

  committed
  0a7101d

• chore: clean out unrelated items from test

  mikevespi

  committed
  85ce6b4

• chore: cleanup commit_form_change_internal

  mikevespi

  committed
  5c1c620

• chore: fix contact index clashes from happening when both committing and pending form changes create the same contact index

  mikevespi

  committed
  3a592c8

• test: fix contact scenarios in concurrent revision test

  mikevespi

  committed
  94b1142

• test: add emission_intensity and funding_parameter tests

  mikevespi

  committed
  59d154d

• test: confirm form_data_record_ids are being set in concurrent creates test

  mikevespi

  committed
  f15e533

• test: add tests for concurrent revisions that discard form changes

  Show description for 1a2ac24
  mikevespi

  committed
  1a2ac24