Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pet-deposit.json #70

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

tekarrawilkinson
Copy link
Contributor

@tekarrawilkinson tekarrawilkinson commented Oct 1, 2024

@tekarrawilkinson
Copy link
Contributor Author

tekarrawilkinson commented Jan 16, 2025

@prchristenson @sbuhovac @Iliana777 @cevenden this rule is ready for validation testing

@sbuhovac
Copy link

Cris (@cevenden) and I reviewed the pet deposit rule as part of Validation Testing and here's our feedback.

  • Input description "Has repayment agreement or promise to pay" sounds like the client already signed a repayment form but that's not the case at the initial eligibility stage. It might be more accurate to say "Agrees in writing to repay" instead.

  • Input 'requestedAmount" is described as "Requested amount of supplement by client if less than full eligible amount of supplement". This description makes it sound like this is not a required field if not less than half rent but it is a required field. To make it simpler, we could rename it to "Requested amount of supplement by client".

  • Input "Tenancy is a valid tenancy under the Residential Tenancy Act" could be modified to say "Tenancy is a valid tenancy under the Residential Tenancy Act or for a housing unit owned by a co-op" to match policy.

  • When we select "No" to inpit 'hasRepaymentAgreement' there is no output 'isEligible' showing up. It should show up with FALSE result. This issue also shows up with some other combinations so we suggest to review the Table.

  • There is no output "Reason" when 'isEligble' results in FALSE. The most recent rules had "Reason" output so we need to be consistent across all rules.

@tekarrawilkinson @prchristenson @Iliana777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants