Fix/input extraction #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwekkenbc
approved these changes
Dec 20, 2024
| const minValue = (numberValues && parseInt(numberValues[0], 10)) || 0; | ||
|
|
||
| console.log(numberValues, 'number values'); |
There was a problem hiding this comment.
Console log left in (two more further below as well)
There was a problem hiding this comment.
Thank you! Forgot cleanup.
Comment on lines
281
to
286
| return text | ||
| ?.trim() | ||
| ?.replace(/[\[\]()]/g, '') | ||
| ?.replace(/[''"]/g, '') | ||
| ?.replace(/\s+/g, ' ') | ||
| ?.trim(); |
There was a problem hiding this comment.
I suck at regex, but I think you can shorten it to:
text
?.trim()
?.replace(/[\[\]()'"‘’“”]/g, '')
?.replace(/\s+/g, ' ');
Not sure you need any of the double trim functions on any of the cleanValue functions either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix handling of 'today' for validations and generating of scenarios.
Add additional cleaning to validation inputs to allow for improved matching.
Increase variability of items generated using array of text options from validations.
Fix capturing of unique inputs for accurately displaying used/unused inputs on the BRM App.