Dev

.github/workflows/eslint.yml

@@ -29,10 +29,3 @@ jobs:
 
       - name: Run ESLint
         run: npm run lint:pipeline
-        continue-on-error: true
-
-      - name: Upload ESLint report
-        uses: actions/upload-artifact@v4
-        with:
-          name: eslint-report
-          path: eslint-report.html

README.md

@@ -14,6 +14,8 @@ Before running your application locally, you'll need some environment variables.
 
 - MONGODB_URL: The URL for connecting to the MongoDB instance you created in the previous step. Set it to something like mongodb://localhost/nest.
 - FRONTEND_URI: The URI for the frontend application. Set it to http://localhost:8080.
+- GITHUB_RULES_BRANCH: Specifies which branch Klamm is syncing with
+- GITHUB_TOKEN: Optional github token to mitigate issues with rate limiting
 - GITHUB_APP_CLIENT_ID
 - GITHUB_APP_CLIENT_SECRET
 - KLAMM_API_URL: The base URL of your Klamm API

package.json

@@ -13,7 +13,7 @@
     "start:debug": "nest start --debug --watch",
     "start:prod": "node dist/main",
     "lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
-    "lint:pipeline": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix --format=html --output-file=eslint-report.html",
+    "lint:pipeline": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix --max-warnings=0",
     "test": "jest",
     "test:watch": "jest --watch",
     "test:cov": "jest --coverage",

src/api/decisions/decisions.controller.ts

@@ -1,6 +1,7 @@
 import { Controller, Post, Query, Body, HttpException, HttpStatus } from '@nestjs/common';
 import { DecisionsService } from './decisions.service';
 import { EvaluateDecisionDto, EvaluateDecisionWithContentDto } from './dto/evaluate-decision.dto';
+import { ValidationError } from './validations/validation.error';
 
 @Controller('api/decisions')
 export class DecisionsController {
@@ -11,7 +12,11 @@ export class DecisionsController {
     try {
       return await this.decisionsService.runDecisionByContent(ruleContent, context, { trace });
     } catch (error) {
-      throw new HttpException(error.message, HttpStatus.INTERNAL_SERVER_ERROR);
+      if (error instanceof ValidationError) {
+        throw new HttpException(error.message, HttpStatus.BAD_REQUEST);
+      } else {
+        throw new HttpException(error.message, HttpStatus.INTERNAL_SERVER_ERROR);
+      }
     }
   }
 

src/api/decisions/decisions.service.spec.ts

@@ -2,6 +2,7 @@ import { ConfigService } from '@nestjs/config';
 import { Test, TestingModule } from '@nestjs/testing';
 import { ZenEngine, ZenDecision, ZenEvaluateOptions } from '@gorules/zen-engine';
 import { DecisionsService } from './decisions.service';
+import { ValidationService } from './validations/validations.service';
 import { readFileSafely } from '../../utils/readFile';
 
 jest.mock('../../utils/readFile', () => ({
@@ -11,6 +12,7 @@ jest.mock('../../utils/readFile', () => ({
 
 describe('DecisionsService', () => {
   let service: DecisionsService;
+  let validationService: ValidationService;
   let mockEngine: Partial<ZenEngine>;
   let mockDecision: Partial<ZenDecision>;
 
@@ -23,11 +25,13 @@ describe('DecisionsService', () => {
     };
 
     const module: TestingModule = await Test.createTestingModule({
-      providers: [ConfigService, DecisionsService, { provide: ZenEngine, useValue: mockEngine }],
+      providers: [ConfigService, DecisionsService, ValidationService, { provide: ZenEngine, useValue: mockEngine }],
     }).compile();
 
     service = module.get<DecisionsService>(DecisionsService);
+    validationService = module.get<ValidationService>(ValidationService);
     service.engine = mockEngine as ZenEngine;
+    jest.spyOn(validationService, 'validateInputs').mockImplementation(() => {});
   });
 
   describe('runDecision', () => {

src/api/decisions/decisions.service.ts

@@ -3,6 +3,8 @@ import { ZenEngine, ZenEvaluateOptions } from '@gorules/zen-engine';
 import { ConfigService } from '@nestjs/config';
 import { RuleContent } from '../ruleMapping/ruleMapping.interface';
 import { readFileSafely, FileNotFoundError } from '../../utils/readFile';
+import { ValidationService } from './validations/validations.service';
+import { ValidationError } from './validations/validation.error';
 
 @Injectable()
 export class DecisionsService {
@@ -16,12 +18,19 @@ export class DecisionsService {
   }
 
   async runDecisionByContent(ruleContent: RuleContent, context: object, options: ZenEvaluateOptions) {
+    const validator = new ValidationService();
+    const ruleInputs = ruleContent?.nodes?.filter((node) => node.type === 'inputNode')[0]?.content;
     try {
+      validator.validateInputs(ruleInputs, context);
       const decision = this.engine.createDecision(ruleContent);
       return await decision.evaluate(context, options);
     } catch (error) {
-      console.error(error.message);
-      throw new Error(`Failed to run decision: ${error.message}`);
+      if (error instanceof ValidationError) {
+        throw new ValidationError(`Invalid input: ${error.message}`);
+      } else {
+        console.error(error.message);
+        throw new Error(`Failed to run decision: ${error.message}`);
+      }
     }
   }
 

src/api/decisions/validations/validation.error.ts

@@ -0,0 +1,19 @@
+export class ValidationError extends Error {
+  constructor(message: string) {
+    super(message);
+    this.name = 'ValidationError';
+    Object.setPrototypeOf(this, ValidationError.prototype);
+  }
+
+  getErrorCode(): string {
+    return 'VALIDATION_ERROR';
+  }
+
+  toJSON(): object {
+    return {
+      name: this.name,
+      message: this.message,
+      code: this.getErrorCode(),
+    };
+  }
+}