Add validation error handling #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brysonjbest
commented
Oct 21, 2024
brysonjbest
commented
- Inputs are checked against the given validation data prior to rule run
- Errors are thrown by the api regarding how the data does not match the required inputs.
- Data is first validated for matching type, and then validated for matching the specific requirements of the field.
- Errors are descriptive regarding the input requirements.
- Integrated this error process into CSV generation/processing as well, so test scenarios processed by CSV fail and provide feedback in the 'Error?' column regarding any errors with input.
- Fixed an additional bug regarding deletion handling and updates on the admin page introduced in Search/Filter rules API support #41.
timwekkenbc
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Really nice having a proper custom error like this. However, should change the filename because it's not a service.
There was a problem hiding this comment.
Thank you, completely missed that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.