Feature - input / output rulemaps for linked rules #23
Conversation
brysonjbest
commented
Jul 23, 2024
•
brysonjbest
commented
- Linked rules recursively compile all inputs and outputs into the top-level rule
- Update to fix bug on handling of csv generation for comma escapes
There was a problem hiding this comment.
I think it looks good. This stuff just continues to get more and more annoyingly convoluted though - that's not a comment about your implementation though, just about the difficulty of approaching the problem this way. Alternative approaches such as where the rule author defines the input schema look more and more appealing.
| const uniqueFieldsMap = new Map<string, any>(); | ||
|
|
||
| fields.forEach((field) => { | ||
| uniqueFieldsMap.set(field.property, field); | ||
| }); |
There was a problem hiding this comment.
I think you can just use map here: const uniqueFieldsMap = new Map(fields.map(field => [field.property, field]));
There was a problem hiding this comment.
Updated! Definitely cleaner, thanks :)
| { key: 'expr1', value: 'field3' }, | ||
| { key: 'expr2', value: 'complexExpr + 2' }, |
There was a problem hiding this comment.
First, thanks for these tests as I was wondering what the difference between a simple vs complex expression looked like. Second, I think the first one here is still a simple one though, right?
There was a problem hiding this comment.
Updated so they are both complex. Initially had only one as then you could compare in the same test and see that it worked correctly while not impacting non-complex expressions, but it's sort of redundant with the simple expressions test so revised per your comment.
