Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/nested inputs #22

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Feature/nested inputs #22

merged 2 commits into from
Jul 18, 2024

Conversation

brysonjbest
Copy link
Collaborator

@brysonjbest brysonjbest commented Jul 18, 2024 •
edited
Loading

  • update api to handle arrays of objects as input variables for csv processing
  • update formatting of variables to correctly handle dates entered as "yyyy-mm-dd"

@brysonjbest brysonjbest requested a review from timwekkenbc July 18, 2024 17:45
timwekkenbc
timwekkenbc approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@timwekkenbc timwekkenbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit hard to follow this code, but I think that's more just the nature of the problem. Wouldn't mind some comments and test cases in future to better understand what it's doing. But looks good to me.

@brysonjbest brysonjbest merged commit 590a4df into dev Jul 18, 2024
2 checks passed
@brysonjbest brysonjbest deleted the feature/nested-inputs branch December 19, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timwekkenbc timwekkenbc timwekkenbc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brysonjbest @timwekkenbc