Feature/rulemapping #10

brysonjbest · 2024-06-11T16:52:00Z

Added rule mapping feature that generates input/output/results schemas from rules.
Added testing suite for rule mapping.
Schema generation works:
on files
post requests with rule data
post requests with trace data from run rules

…JSON documents API endpoints, Added first dto for decisions API

timwekkenbc

Looks really good! There are a few minor things you might want to look into - mostly just around making sure there is as little unnecessary repetition as possible

src/api/ruleMapping/dto/evaluate-rulemapping.dto.ts

src/api/ruleMapping/ruleMapping.service.ts

src/api/ruleMapping/ruleMapping.interface.ts

…s directory (for adding a rule, getting list of documents to potentially add)

…value

brysonjbest · 2024-06-12T21:05:11Z

Updated to incorporate latest brms rules folder location changes on dev.

timwekkenbc

Looks good to me!

Bryson and others added 18 commits June 4, 2024 15:47

Initialize rulemapping feature to map inputs and outputs from rules.

2408b73

Added ZenEngine implementation, Added decisions API endpoints, Added …

43c6345

…JSON documents API endpoints, Added first dto for decisions API

Initialize rulemapping feature to map inputs and outputs from rules.

39a05ab

Add unique inputs mapping.

4f0eb13

Remove unused routes and add file query.

f249264

Remove extraneous extension from filepath name.

b7df620

Update tests for rulemapping service.

e781703

Remove unused imports from test.

617ad33

Update error handling to throw error properly.

06f5a65

Update tests for rulemapping controller.

ff655c9

Add finaloutput function to pull results from rule schema.

73c56c7

Update rules location.

4e3d1dc

Update rules location.

b55f990

Refactor inputs/outputs.

0e644a9

Add output schema generation using results trace.

935baed

Update to query entire schema from rule run instead of only outputs.

38a4f3e

Update formatting and testing details.

1e753d9

Merge dev.

e5e3303

brysonjbest requested a review from timwekkenbc June 11, 2024 16:52

brysonjbest self-assigned this Jun 11, 2024

timwekkenbc reviewed Jun 11, 2024

View reviewed changes

brysonjbest and others added 9 commits June 11, 2024 15:01

Update interfaces to classes and include zen-engine extension.

a18ab51

Update ruleschemafile function to use dependency injection.

beebed2

Consolidate input and output extraction into one function.

283724d

Update formatting of Module controllers and providers.

52b3854

rebased to dev.

3ad67ed

Copy in rules files from the rules repo

184309c

Dispatch workflow added so project can be re-deployed when rules update

10da70b

Update backend rules data to work better with rules in the local rule…

a2b8f9d

…s directory (for adding a rule, getting list of documents to potentially add)

Update README for accessing rules from rules repo

ebd3ace

timwekkenbc and others added 5 commits June 12, 2024 12:16

Updated RULES_DIRECTORY to be an environment variable with a default …

c5132bd

…value

ruleData schema updated to use mongo ObjectId strings for id

2b0f7c5

Updated github action to pass branch name properly to Docker

97fb87c

Update with env variable for directory.

5d5a0cf

Update testing for env.

35cffa5

brysonjbest requested a review from timwekkenbc June 12, 2024 21:05

timwekkenbc changed the base branch from dev to main June 12, 2024 21:20

timwekkenbc changed the base branch from main to dev June 12, 2024 21:20

brysonjbest added 2 commits June 12, 2024 15:33

Move logic from controller to service.

9a1b016

Remove extra word in rulefile test path.

12511d0

timwekkenbc approved these changes Jun 12, 2024

View reviewed changes

Revert classes to interfaces, and export classes directly in DTO.

35df371

brysonjbest merged commit 48181f5 into dev Jun 12, 2024
2 checks passed

brysonjbest deleted the feature/rulemapping branch December 19, 2024 23:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/rulemapping #10

Feature/rulemapping #10

brysonjbest commented Jun 11, 2024 •

edited

Loading

timwekkenbc left a comment

brysonjbest commented Jun 12, 2024

timwekkenbc left a comment

Feature/rulemapping #10

Feature/rulemapping #10

Conversation

brysonjbest commented Jun 11, 2024 • edited Loading

timwekkenbc left a comment

Choose a reason for hiding this comment

brysonjbest commented Jun 12, 2024

timwekkenbc left a comment

Choose a reason for hiding this comment

brysonjbest commented Jun 11, 2024 •

edited

Loading