Merge pull request #54 from bcgov/dev

Remove klamm sync error causing crash
bcgov · Nov 12, 2024 · f77c88a · f77c88a
2 parents 59ed523 + e9e05b0
commit f77c88a
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 11 deletions.
diff --git a/src/api/klamm/klamm.service.spec.ts b/src/api/klamm/klamm.service.spec.ts
@@ -273,16 +273,6 @@ describe('KlammService', () => {
     );
   });
 
-  it('should handle error in _updateRuleInKlamm', async () => {
-    const mockRulePayload = { name: 'rule1' } as KlammRulePayload;
-    const mockRuleId = 1;
-    jest.spyOn(service.axiosKlammInstance, 'put').mockRejectedValue(new Error('Error'));
-
-    await expect(service['_updateRuleInKlamm'](mockRuleId, mockRulePayload)).rejects.toThrow(
-      'Error updating rule 1 in Klamm',
-    );
-  });
-
   it('should update last sync timestamp correctly', async () => {
     jest.spyOn(klammSyncMetadata, 'findOneAndUpdate').mockResolvedValue(undefined);
 

diff --git a/src/api/klamm/klamm.service.ts b/src/api/klamm/klamm.service.ts
@@ -259,7 +259,6 @@ export class KlammService {
       await this.axiosKlammInstance.put(`${process.env.KLAMM_API_URL}/api/brerules/${currentKlamRuleId}`, rulePayload);
     } catch (error) {
       this.logger.error(`Error updating rule ${currentKlamRuleId} in Klamm:`, error.message);
-      throw new Error(`Error updating rule ${currentKlamRuleId} in Klamm`);
     }
   }