Merge pull request #18 from bcgov/fix/remove-chefs-submissions

Remove any CHEFS and/or submissions functionality

README.md

@@ -1,6 +1,6 @@
 # BRMS API/Backend
 
-This project is the API/Backend for the SDPR Business Rules Engine (BRE) and Business Rules Engine Management System (BRMS). It will act as a middle layer between GoRules, CHEFS, and the [frontend](https://github.com/bcgov/brms-simulator-frontend) or any other integration.
+This project is the API/Backend for the SDPR Business Rules Engine (BRE) and Business Rules Engine Management System (BRMS). It will act primarly as the backend for the [frontend simulator](https://github.com/bcgov/brms-simulator-frontend).
 
 ## Local Development Setup
 
@@ -14,7 +14,6 @@ Before running your application locally, you'll need some environment variables.
 
 - MONGODB_URL: The URL for connecting to the MongoDB instance you created in the previous step. Set it to something like mongodb://localhost/nest.
 - FRONTEND_URI: The URI for the frontend application. Set it to http://localhost:8080.
-- CHEFS_API_URL: The URL for the Chefs API. Set it to https://submit.digital.gov.bc.ca/app/api/v1.
 
 ### Including Rules from the Rules Repository
 

src/api/ruleData/ruleData.controller.ts

@@ -11,7 +11,7 @@ export class RuleDataController {
     try {
       return await this.ruleDataService.getAllRuleData();
     } catch (error) {
-      throw new HttpException('Error getting submissions', HttpStatus.INTERNAL_SERVER_ERROR);
+      throw new HttpException('Error getting list of rule data', HttpStatus.INTERNAL_SERVER_ERROR);
     }
   }
 
@@ -20,7 +20,7 @@ export class RuleDataController {
     try {
       return await this.ruleDataService.getRuleData(ruleId);
     } catch (error) {
-      throw new HttpException('Error getting submissions', HttpStatus.INTERNAL_SERVER_ERROR);
+      throw new HttpException('Error getting rule data', HttpStatus.INTERNAL_SERVER_ERROR);
     }
   }
 

src/api/ruleData/ruleData.schema.ts

@@ -13,12 +13,6 @@ export class RuleData {
 
   @Prop({ required: true, description: 'The filename of the JSON file containing the rule' })
   goRulesJSONFilename: string;
-
-  @Prop({ description: 'The ID of the form in Chefs that corresponds to this rule' })
-  chefsFormId: string;
-
-  @Prop({ description: 'The API key of the CHEFS form - needed to access submissions' })
-  chefsFormAPIKey: string;
 }
 
 export const RuleDataSchema = SchemaFactory.createForClass(RuleData);

src/api/ruleData/ruleData.service.spec.ts

@@ -8,8 +8,6 @@ export const mockRuleData = {
   _id: 'testId',
   title: 'Title',
   goRulesJSONFilename: 'filename.json',
-  chefsFormId: 'formId',
-  chefsFormAPIKey: '12345',
 };
 
 export const mockServiceProviders = [

src/api/ruleData/ruleData.service.ts

@@ -77,14 +77,6 @@ export class RuleDataService {
     }
   }
 
-  async getFormAPIKeyForFormId(chefsFormId: string): Promise<string> {
-    const ruleData = await this.ruleDataModel.findOne({ chefsFormId }).exec();
-    if (!ruleData) {
-      throw new Error(`Rule data not found for CHEFS form id: ${chefsFormId}`);
-    }
-    return ruleData.chefsFormAPIKey;
-  }
-
   /**
    * Add rules to the db that exist in the repo, but not yet the db
    */

src/app.module.ts

@@ -8,8 +8,6 @@ import { DecisionsController } from './api/decisions/decisions.controller';
 import { DecisionsService } from './api/decisions/decisions.service';
 import { DocumentsController } from './api/documents/documents.controller';
 import { DocumentsService } from './api/documents/documents.service';
-import { SubmissionsController } from './api/submissions/submissions.controller';
-import { SubmissionsService } from './api/submissions/submissions.service';
 import { RuleMappingController } from './api/ruleMapping/ruleMapping.controller';
 import { RuleMappingService } from './api/ruleMapping/ruleMapping.service';
 import { ScenarioData, ScenarioDataSchema } from './api/scenarioData/scenarioData.schema';
@@ -36,17 +34,9 @@ import { ScenarioDataService } from './api/scenarioData/scenarioData.service';
     RuleDataController,
     DecisionsController,
     DocumentsController,
-    SubmissionsController,
     RuleMappingController,
     ScenarioDataController,
   ],
-  providers: [
-    RuleDataService,
-    DecisionsService,
-    DocumentsService,
-    SubmissionsService,
-    RuleMappingService,
-    ScenarioDataService,
-  ],
+  providers: [RuleDataService, DecisionsService, DocumentsService, RuleMappingService, ScenarioDataService],
 })
 export class AppModule {}