Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Improvements #58

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Refactoring Improvements #58

merged 1 commit into from
Jan 13, 2025

Conversation

timwekkenbc
Copy link
Collaborator

  • Fixed how layout is handled so that it can handle both rule pages and list pages without janky css
  • Removed unused CSS, Added CSS vars for commonly used values such as breakpoints and colors, Switched to using rem instead of px for padding to make more accessible
  • Smoothed out how the page loads in
  • Reduced load called when getting title for a page so it is more performant

… list pages without janky css, Removed unused CSS, Added CSS vars for commonly used values such as breakpoints and colors, Switched to using rem instead of px for padding to make more accessible, Smoothed out how the page loads in, Reduced load called when getting title for a page so it is more performant
Copy link
Collaborator

@brysonjbest brysonjbest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the move to the root css variables, especially for the rule state colours and breakpoints! Makes cohesive design so straightforward.

Thank you for all the work you put into refactoring this! It looks so good!

@timwekkenbc timwekkenbc merged commit c9ad186 into dev Jan 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants