New warnings when editing a file that show missing Klamm connections #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
brysonjbest
force-pushed
the
dev
branch
8 times, most recently
from
ae667dd to
8c28312
Compare
timwekkenbc
force-pushed
the
dev
branch
9 times, most recently
from
422e96d to
69ed3da
Compare
timwekkenbc
force-pushed
the
feature/klamm-connection-warnings
branch
from
d150ed9 to
16b81c2
Compare
…and unnused Klamm connections, New warnings supported by notification component and floating button
timwekkenbc
force-pushed
the
feature/klamm-connection-warnings
branch
from
16b81c2 to
73bec81
Compare
brysonjbest
approved these changes
Sep 24, 2024
|
|
||
| interface SavePublishProps { | ||
| filePath: string; | ||
| ruleContent: { nodes: []; edges: [] }; |
There was a problem hiding this comment.
Could we update this to use the DecisionGraphType from "@gorules/jdm-editor", or its nested DecisionNode/DecisionEdge types?
There was a problem hiding this comment.
Good point. Updated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend changes that support this: bcgov/brm-backend#34