Fixed lint issues

app/components/GithubAuthProvider.tsx

@@ -9,7 +9,7 @@ export interface GithubAuthContextType {
 
 const GithubAuthContext = createContext<GithubAuthContextType | undefined>(undefined);
 
-export const GithubAuthProvider: React.FC<{ authInfo?: GithubAuthContextType; children: React.ReactNode }> = ({
+export const GithubAuthProvider: React.FC<{ authInfo: GithubAuthContextType | null; children: React.ReactNode }> = ({
   authInfo,
   children,
 }) => {

app/components/RuleViewerEditor/RuleViewerEditor.tsx

@@ -251,6 +251,7 @@ export default function RuleViewerEditor({
         ),
       }),
     ],
+    // eslint-disable-next-line react-hooks/exhaustive-deps
     []
   );
 

app/components/SavePublish/SavePublishWarnings.tsx

@@ -79,6 +79,7 @@ export default function SavePublishWarnings({ filePath, ruleContent, isSaving }:
 
   useEffect(() => {
     getMisconnectedFields();
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [ruleContent]);
 
   useEffect(() => {
@@ -91,6 +92,7 @@ export default function SavePublishWarnings({ filePath, ruleContent, isSaving }:
     if (misconnectedFieldsPanelOpen) {
       warnOfMisconnectedFields();
     }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [misconnectedFields, misconnectedFieldsPanelOpen]);
 
   return (

app/errors/noorgaccess/page.tsx

@@ -1,11 +1,11 @@
 "use client";
-import { useEffect } from "react";
+import { Suspense, useEffect } from "react";
 import { useSearchParams } from "next/navigation";
 import axios from "axios";
 import Image from "next/image";
 import { Alert, Button } from "antd";
 
-export default function NoOrgAccess() {
+function NoOrgAccessComponent() {
   const searchParams = useSearchParams();
   const returnUrl = searchParams.get("returnUrl");
 
@@ -22,8 +22,8 @@ export default function NoOrgAccess() {
           <div>
             <p>Your account has no organization authorization.</p>
             <p>
-              Hit the "Re-Login" button below and then make sure to hit the "Authorize" button shown below before
-              continuing.
+              Hit the &quot;Re-Login&quot; button below and then make sure to hit the &quot;Authorize&quot; button shown
+              below before continuing.
             </p>
             <div>
               <Image src="/images/github-authorize-screen.png" alt="GitHub Authorize Screen" width={500} height={370} />
@@ -40,3 +40,11 @@ export default function NoOrgAccess() {
     </div>
   );
 }
+
+export default function NoOrgAccess() {
+  return (
+    <Suspense fallback={<div>Loading...</div>}>
+      <NoOrgAccessComponent />
+    </Suspense>
+  );
+}

app/hooks/useGithubAuth.ts

@@ -1,8 +1,16 @@
 import { redirect } from "next/navigation";
 import { headers, cookies } from "next/headers";
 import { isGithubAuthTokenValid, AuthFailureReasons } from "../utils/githubApi";
+import { GithubAuthContextType } from "../components/GithubAuthProvider";
+
+export default async function useGithubAuth(
+  redirectPath: string,
+  required: boolean = true
+): Promise<GithubAuthContextType | null> {
+  if (!required) {
+    return null;
+  }
 
-export default async function useGithubAuth(redirectPath: string) {
   const githubAuthToken = cookies().get("github-authentication-token")?.value;
   const githubAuthUsername = cookies().get("github-authentication-username")?.value;
   const { valid, reason } = await isGithubAuthTokenValid(githubAuthToken);

app/rule/[ruleId]/page.tsx

@@ -17,12 +17,10 @@ export default async function Rule({
   // Get version of rule to use
   const { version } = searchParams;
 
-  let githubAuthInfo: GithubAuthContextType | undefined;
-  if (version === RULE_VERSION.draft) {
-    // Ensure user is first logged into github so they can save what they edit
-    // If they are not, redirect them to the oauth flow
-    githubAuthInfo = (await useGithubAuth(`rule/${ruleId}?version=${version}`)) as GithubAuthContextType;
-  }
+  // Ensure user is first logged into github so they can save what they edit
+  // If they are not, redirect them to the oauth flow
+  const oAuthRequired = version === RULE_VERSION.draft; // only require oauth if editing a draft
+  const githubAuthInfo = await useGithubAuth(`rule/${ruleId}?version=${version}`, oAuthRequired);
 
   // Get rule details and json content for the rule id
   const { ruleInfo, ruleContent } = await getRuleDataForVersion(ruleId, version);

app/rule/new/page.tsx

@@ -5,10 +5,10 @@ import NewRule from "./NewRule";
 export default async function NewRuleWrapper() {
   // Ensure user is first logged into github so they can save what they edit
   // If they are not, redirect them to the oauth flow
-  const { githubAuthToken, githubAuthUsername } = await useGithubAuth("rule/new");
+  const githubAuthInfo = await useGithubAuth("rule/new");
 
   return (
-    <GithubAuthProvider authInfo={{ githubAuthToken, githubAuthUsername }}>
+    <GithubAuthProvider authInfo={githubAuthInfo}>
       <NewRule />
     </GithubAuthProvider>
   );