Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-627: Fix Survey Spatial Telemetry Components #1453

Merged
merged 25 commits into from
Dec 17, 2024

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Dec 14, 2024

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-627

Description of Changes

Survey page -> Telemetry map/table components

  • Update/fix the survey spatial telemetry components (from the survey page).
    • Added new sub-tabs to that component, so you can see a list of deployments or telemetry records

Manage Telemetry table

  • Fix Manage Telemetry table sorting bug.

Deployment rename

  • Rename all instances of deployment2 to deployment
  • Rename all instances of deployments2 to deployments
  • Rename all instances of deployment2_id to deployment_id
  • etc...

Old deployment table

  • Add migration to rename old deployment table to deployment_old, so we can leverage the old data when we migrate the BCTW data over to SIMS.

Testing Notes

Needs to be reviewed after #1452.

@NickPhura NickPhura added the Not Ready For Review Addressing feedback and/or refactoring label Dec 14, 2024
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 6.31579% with 178 lines in your changes missing coverage. Please review.

Project coverage is 45.59%. Comparing base (19c4239) to head (4d304ce).
Report is 1 commits behind head on SIMSBIOHUB-627.

Files with missing lines Patch % Lines
...ponents/telemetry/SurveySpatialDeploymentTable.tsx 0.00% 48 Missing ⚠️
...observation/SurveySpatialObservationDeployment.tsx 0.00% 32 Missing ⚠️
...mponents/telemetry/SurveySpatialTelemetryTable.tsx 0.00% 21 Missing ⚠️
app/src/contexts/telemetryTableContext.tsx 0.00% 17 Missing ⚠️
...emetry-repositories/telemetry-vendor-repository.ts 0.00% 14 Missing ⚠️
...ents/observation/SurveySpatialObservationTable.tsx 0.00% 8 Missing ⚠️
.../observation/SurveySpatialObservationContainer.tsx 0.00% 7 Missing ⚠️
...ents/telemetry/SurveySpatialTelemetryContainer.tsx 0.00% 7 Missing ⚠️
app/src/hooks/api/useTelemetryDeploymentApi.ts 0.00% 4 Missing ⚠️
...p/src/features/surveys/telemetry/TelemetryPage.tsx 0.00% 3 Missing ⚠️
... and 10 more
Additional details and impacted files
@@                Coverage Diff                 @@
##           SIMSBIOHUB-627    #1453      +/-   ##
==================================================
- Coverage           45.74%   45.59%   -0.15%     
==================================================
  Files                 881      883       +2     
  Lines               23178    23254      +76     
  Branches             3410     3428      +18     
==================================================
  Hits                10603    10603              
- Misses              11965    12041      +76     
  Partials              610      610              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura added Ready For Review PR is ready for review and removed Not Ready For Review Addressing feedback and/or refactoring labels Dec 16, 2024
@NickPhura NickPhura marked this pull request as ready for review December 16, 2024 21:56
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
29.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@NickPhura NickPhura merged commit ebf2c96 into SIMSBIOHUB-627 Dec 17, 2024
16 of 21 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-627-cleanup-2 branch December 17, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants