Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alert banners from animal and telemetry page #1449

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Conversation

mauberti-bc
Copy link
Collaborator

Links to Jira Tickets

  • N/A

Description of Changes

  • The current system alert banners do not display well on the animal and telemetry pages so removing them for now
  • We'll have to design a different way to view alerts on these pages

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.93%. Comparing base (c8dfb81) to head (9b08d72).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1449   +/-   ##
=======================================
  Coverage   45.93%   45.93%           
=======================================
  Files         848      848           
  Lines       22452    22452           
  Branches     3333     3333           
=======================================
  Hits        10313    10313           
  Misses      11529    11529           
  Partials      610      610           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MacQSL
MacQSL previously approved these changes Dec 10, 2024
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔭

@mauberti-bc mauberti-bc marked this pull request as ready for review December 10, 2024 22:52
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@NickPhura NickPhura merged commit 66b47fc into dev Dec 11, 2024
24 checks passed
@NickPhura NickPhura deleted the alert-banners branch December 11, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants